[pull] main from microsoft:main #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
Summary: Pull Request resolved: facebook#49586 Reverting facebook#49413 as it was causing a crash with assertion failure in ReactViewGroup.addViewWithSubviewClippingEnabled() Changelog: [INTERNAL] revert Kotlin conversion due to crash Reviewed By: sbuggay Differential Revision: D69953848 fbshipit-source-id: b438fb928a4849f3dbad6a9d59d0f48449035fd6
…k#49574) Summary: Pull Request resolved: facebook#49574 Changelog: [General][Internal] add the event tracking when connection to debugger is closed Reviewed By: huntie Differential Revision: D69917816 fbshipit-source-id: 4a15288333c0d5b7fb821d046fa9c615bb25223e
…ook#49572) Summary: Pull Request resolved: facebook#49572 Changelog: [internal] This adds a test to verify the behavior of 2 feature flags: synchronous state updates and UI consistency. Reviewed By: javache Differential Revision: D69932313 fbshipit-source-id: 341cfff3fa533503a293f6ccd0282442ba63d430
…es (facebook#49529) Summary: Pull Request resolved: facebook#49529 Changelog: [Internal] - Added TouchableWithoutFeedback to buildTypes and aligned Flow with TS types Reviewed By: huntie Differential Revision: D69855221 fbshipit-source-id: a1de660e02a90f8e1c181b8e0c5dfdbaa4d2c75c
…ook#49561) Summary: Pull Request resolved: facebook#49561 Changelog: [Internal] - Added TouchableNativeFeedback to buildTypes and aligned Flow types Reviewed By: huntie Differential Revision: D69858177 fbshipit-source-id: 4bd55cba9a9eb1a1d304911cf929b363205a20d5
…tions (facebook#49560) Summary: Pull Request resolved: facebook#49560 Changelog: [Internal] - Added TouchableHighlight to buildTypes and moved comments from TS definitions Reviewed By: huntie Differential Revision: D69919248 fbshipit-source-id: 66b615df60862a53132bd7b2ae9f54065c444e22
Summary: Pull Request resolved: facebook#49589 We should not be attempting to compile anything related to the annotation processor in either Kotlin or Java. This excludes those folders from the Kotlin compilation task as the CI is currently red because of it. Changelog: [Internal] [Changed] - Reviewed By: huntie Differential Revision: D69981620 fbshipit-source-id: 7e2d534023ab1c00e5aadf8546440a4cc4c01ec0
Summary: Pull Request resolved: facebook#49578 I'm making this class internal as I've verified that there are no meaningful usages. [Source](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+com.facebook.react.devsupport.RedBoxContentView) Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D69934543 fbshipit-source-id: 1fdf74a4aa34a641974aae71534555b86fe02d9c
Summary: Pull Request resolved: facebook#49577 I'm making this class internal as I verified that there are no meaningful OSS usages. [Source](https://www.google.com/url?q=https://github.com/search?type%3Dcode%26q%3DNOT%2Bis%253Afork%2BNOT%2Borg%253Afacebook%2BNOT%2Brepo%253Areact-native-tvos%252Freact-native-tvos%2BNOT%2Brepo%253Anuagoz%252Freact-native%2BNOT%2Brepo%253A2lambda123%252Freact-native%2BNOT%2Brepo%253Abeanchips%252Ffacebookreactnative%2BNOT%2Brepo%253AfabOnReact%252Freact-native-notes%2BNOT%2Buser%253Ahuntie%2BNOT%2Buser%253Acortinico%2BNOT%2Brepo%253AMaxdev18%252Fpowersync_app%2BNOT%2Brepo%253Acarter-0%252Finstagram-decompiled%2BNOT%2Brepo%253Am0mosenpai%252Finstadamn%2BNOT%2Brepo%253AA-Star100%252FA-Star100-AUG2-2024%2BNOT%2Brepo%253Alclnrd%252Fdetox-scrollview-reproductible%2BNOT%2Brepo%253ADionisisChytiris%252FWorldWiseTrivia_Main%2BNOT%2Brepo%253Apast3l%252Fhi2%2BNOT%2Brepo%253AoneDotpy%252FCaribouQuest%2BNOT%2Brepo%253Abejayoharen%252Fdailytodo%2BNOT%2Brepo%253Amolangning%252Freversing-discord%2BNOT%2Brepo%253AScottPrzy%252Freact-native%2BNOT%2Brepo%253Agabrieldonadel%252Freact-native-visionos%2BNOT%2Brepo%253AGabriel2308%252FTestes-Soft%2BNOT%2Brepo%253Adawnzs03%252FflakyBuild%2BNOT%2Brepo%253Acga2351%252Fcode%2BNOT%2Brepo%253Astreeg%252Ftcc%2BNOT%2Brepo%253Asoftware-mansion-labs%252Freact-native-swiftui%2Bcom.facebook.react.devsupport.PerftestDevSupportManager&sa=D&source=editors&ust=1740080026490626&usg=AOvVaw2lrtsZSaLDgxSkejXVrRrp) Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D69934544 fbshipit-source-id: 00fc90907a27026269592e4cdfa8aed6e70a7c6e
) Summary: Pull Request resolved: facebook#49517 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69742877 fbshipit-source-id: ccd99b29aed4ec4ef8c0b7b2a57763f716be411e
…49557) Summary: While `readline` is referenced in `packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js`, this references the `node:readline` module by default. The extra package seems to have been installed and included accidentally, as the `attachKeyHandlers` file uses an export from `node:readline` that's never been present in `npm:readline`. Since the name matches but Node.js will always prefer built-in/code modules, this dependency is dangling and can never be reached, since it's name is shadowed (as also stated in their readme). This can be reproduced by comparing `require('readline')` and `require('../../node_modules/readline')` in `packages/community-cli-plugin`. The flow types also confirm this. This overall seems highly safe to drop. ## Changelog: [INTERNAL] [CHANGED] - Remove shadowed and unused readline npm package from community-cli-plugin Pull Request resolved: facebook#49557 Test Plan: Prior to changes applied: ```sh $ node -e 'console.log(require("readline") === require("node:readline"))' true ``` Reviewed By: cipolleschi Differential Revision: D69925999 Pulled By: huntie fbshipit-source-id: 802fdaa396630b44d5aacefeb9c2473fb53d167e
Differential Revision: D69934543 Original commit changeset: 1fdf74a4aa34 Original Phabricator Diff: D69934543 fbshipit-source-id: 20a3f0011945fc5e1fb9efe25b81cd5e4fdd1b70
Differential Revision: D69934544 Original commit changeset: 00fc90907a27 Original Phabricator Diff: D69934544 fbshipit-source-id: 03aa1de1e594266b88b624dacec8891b1907a07f
Summary: As part of the initiative to reduce the public API surface, this class can be internalized. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+com.facebook.hermes.instrumentation.HermesMemoryDumper). ## Changelog: [INTERNAL] - Make com.facebook.hermes.instrumentation.HermesMemoryDumper internal Pull Request resolved: facebook#49585 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: javache Differential Revision: D69980382 Pulled By: cortinico fbshipit-source-id: 654d62e0961ab471d494fa9769fafa02d3808432
…cies` (facebook#49556) Summary: This package does not seem to be referenced by anything but the tests in `packages/dev-middleware`, so seems like a pretty straightforward change to drop it from `dependencies`. It only seems to be referenced in `packages/dev-middleware/src/__tests__/ServerUtils.js` ## Changelog: [INTERNAL] [CHANGED] - Remove selfsigned from dev-middleware dependencies Pull Request resolved: facebook#49556 Test Plan: - n/a Reviewed By: cipolleschi Differential Revision: D69925928 Pulled By: huntie fbshipit-source-id: bba41f81dba054505ebf196ad37c7a718a6b16da
Summary: Update androidx app compat to the latest version. This is needed as part of facebook#49486 to have access to `fullyDrawnReporter`. ## Changelog: [ANDROID] [CHANGED] - Update androidx app compat to 1.7.0 Pull Request resolved: facebook#49594 Test Plan: Tested in RN tester that it builds fine and works properly. Reviewed By: Abbondanzo Differential Revision: D69988202 Pulled By: cortinico fbshipit-source-id: 0329aa84a76327db535ddba8acf059ebbf1dbdfc
…abel-transformer` (facebook#49558) Summary: Opening this as a separate PR, since I'm not sure if I'm missing something, or if there's any intention behind this. `react-native/metro-babel-transformer` is used by `react-native/metro-config` and is referenced in code there and as a dependency there. It's also sometimes mentioned as package for community CLI users to install directly. However, there's seemingly no reason `react-native/metro-babel-transformer` needs to depend on it, or any code that relies on it directly. ## Changelog: [INTERNAL] [CHANGED] - Remove extraneous `react-native/metro-babel-transformer` dependency from community-cli-plugin Pull Request resolved: facebook#49558 Test Plan: - n/a Reviewed By: robhogan Differential Revision: D69926109 Pulled By: huntie fbshipit-source-id: b89b54890248de4954e5c0ce4afe3a5cb5bfa2c1
…ag (facebook#49590) Summary: Pull Request resolved: facebook#49590 This feature flag was used to validate a fix for handling of events during gesture on pressable. It can now be removed as the flag has been set to true for several internal app (Twilight among others) for several months. Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D69983235 fbshipit-source-id: 89b96b3e4c98ae258982341f56ddc13aa2fe51bd
Summary: Pull Request resolved: facebook#49597 Changelog: [Internal] - Added Switch to buildTypes and aligned Flow with TS types. Reviewed By: huntie Differential Revision: D69984618 fbshipit-source-id: 1fb978bb712be20f0e685af80bef0ac6d78b73ba
…scovery (facebook#49600) Summary: Pull Request resolved: facebook#49600 changelog: [internal] # Context Recent reports of unable to pair or connect to headsets in the Twilight app started ~1 day ago. I used a bisect to narrow down the range of changes https://www.internalfb.com/mobile-bisect/Bi653128483872339, which lead to [changelog](https://www.internalfb.com/intern/changelog/?search=%7B%22key%22%3A%22AND%22%2C%22children%22%3A[%7B%22key%22%3A%22buck_target_is%22%2C%22field%22%3A%22buck_target%22%2C%22value%22%3A%22%2F%2Ffbobjc%2FApps%2FOculus%2FTwilight%3ATwilight%22%7D%2C%7B%22key%22%3A%22branch_first%22%2C%22field%22%3A%22branch%22%2C%22value%22%3A%22master%22%7D%2C%7B%22key%22%3A%22revision_first%22%2C%22field%22%3A%22revision%22%2C%22value%22%3A%22e835199c51fd1b55c3c13c5504f9b5527e201b41%22%7D%2C%7B%22key%22%3A%22branch_last%22%2C%22field%22%3A%22branch%22%2C%22value%22%3A%22master%22%7D%2C%7B%22key%22%3A%22revision_last%22%2C%22field%22%3A%22revision%22%2C%22value%22%3A%22d19e5a6cd5949d65aee30f7e8ce185979b7448af%22%7D]%7D) From there I continued until I found the threshold D69855097 (bad) and D69803512 (good). I tried a direct revert of D69855097 but the changes we spread across another diff D69874923. Reverting the stack of these gets us to here. Could use help understanding what's going on. Reviewed By: sammy-SC Differential Revision: D69987736 fbshipit-source-id: f9d16a460112374f163d235dc3e576d7ad506ebf
facebook#49584) Summary: Migrate com.facebook.react.modules.network.RequestBodyUtil to Kotlin ## Changelog: [INTERNAL] - Migrate com.facebook.react.modules.network.RequestBodyUtil to Kotlin Pull Request resolved: facebook#49584 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: arushikesarwani94 Differential Revision: D69980421 Pulled By: cortinico fbshipit-source-id: aa66661b2b79afdfd41963e7896b9a01f12af5cb
Summary: Pull Request resolved: facebook#49581 I need to be able to find a View with a specific nativeId as part of my implementation of accessibility ordered children. This already exists in Android in `ReactFindViewUtil.kt`. Not much to this implementation. Recursive tree searching. I do not think perf is a big deal here but if we want to optimize this we could implement some nativeId registry and try and get the UIView * from that at the expense of storing that map somewhere. Changelog: [Internal] Reviewed By: vincentriemer Differential Revision: D69868430 fbshipit-source-id: b3648a8dca351bed50534cac2144d7e8ea0a207f
…facebook#49565) Summary: Pull Request resolved: facebook#49565 Original commit changeset: 6ed54f0fab45 Original Phabricator Diff: D69473992 Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D69924542 fbshipit-source-id: 6438d1f6e21728de662a060893b0f08f9285be73
…o Kotlin (facebook#49583) Summary: Migrate com.facebook.react.bridge.queue.MessageQueueThreadHandler to Kotlin ## Changelog: [INTERNAL] - Migrate com.facebook.react.bridge.queue.MessageQueueThreadHandler to Kotlin Pull Request resolved: facebook#49583 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: javache Differential Revision: D69950075 Pulled By: arushikesarwani94 fbshipit-source-id: ddca07860a57816b2ff3b2b8902151686700f5c2
Summary: Pull Request resolved: facebook#49575 I've verified that this class is not used in OSS so I'm making it internal. [Source](https://www.google.com/url?q=https://github.com/search?type%3Dcode%26q%3DNOT%2Bis%253Afork%2BNOT%2Borg%253Afacebook%2BNOT%2Brepo%253Areact-native-tvos%252Freact-native-tvos%2BNOT%2Brepo%253Anuagoz%252Freact-native%2BNOT%2Brepo%253A2lambda123%252Freact-native%2BNOT%2Brepo%253Abeanchips%252Ffacebookreactnative%2BNOT%2Brepo%253AfabOnReact%252Freact-native-notes%2BNOT%2Buser%253Ahuntie%2BNOT%2Buser%253Acortinico%2BNOT%2Brepo%253AMaxdev18%252Fpowersync_app%2BNOT%2Brepo%253Acarter-0%252Finstagram-decompiled%2BNOT%2Brepo%253Am0mosenpai%252Finstadamn%2BNOT%2Brepo%253AA-Star100%252FA-Star100-AUG2-2024%2BNOT%2Brepo%253Alclnrd%252Fdetox-scrollview-reproductible%2BNOT%2Brepo%253ADionisisChytiris%252FWorldWiseTrivia_Main%2BNOT%2Brepo%253Apast3l%252Fhi2%2BNOT%2Brepo%253AoneDotpy%252FCaribouQuest%2BNOT%2Brepo%253Abejayoharen%252Fdailytodo%2BNOT%2Brepo%253Amolangning%252Freversing-discord%2BNOT%2Brepo%253AScottPrzy%252Freact-native%2BNOT%2Brepo%253Agabrieldonadel%252Freact-native-visionos%2BNOT%2Brepo%253AGabriel2308%252FTestes-Soft%2BNOT%2Brepo%253Adawnzs03%252FflakyBuild%2BNOT%2Brepo%253Acga2351%252Fcode%2BNOT%2Brepo%253Astreeg%252Ftcc%2BNOT%2Brepo%253Asoftware-mansion-labs%252Freact-native-swiftui%2Bcom.facebook.react.devsupport.PackagerStatusCheck&sa=D&source=editors&ust=1740079563838123&usg=AOvVaw09B3GTFOynL-bbMHF6M4m2) Changelog: [Internal] [Changed] - Reviewed By: arushikesarwani94 Differential Revision: D69933995 fbshipit-source-id: 77e308bd01fb4d51d4cf54e4666f15b532b43453
Summary: Pull Request resolved: facebook#49595 This is a reland of D69934544 which was previously reverted. Pull Request resolved: facebook#49577 I'm making this class internal as I verified that there are no meaningful OSS usages. [Source](https://www.google.com/url?q=https://github.com/search?type%3Dcode%26q%3DNOT%2Bis%253Afork%2BNOT%2Borg%253Afacebook%2BNOT%2Brepo%253Areact-native-tvos%252Freact-native-tvos%2BNOT%2Brepo%253Anuagoz%252Freact-native%2BNOT%2Brepo%253A2lambda123%252Freact-native%2BNOT%2Brepo%253Abeanchips%252Ffacebookreactnative%2BNOT%2Brepo%253AfabOnReact%252Freact-native-notes%2BNOT%2Buser%253Ahuntie%2BNOT%2Buser%253Acortinico%2BNOT%2Brepo%253AMaxdev18%252Fpowersync_app%2BNOT%2Brepo%253Acarter-0%252Finstagram-decompiled%2BNOT%2Brepo%253Am0mosenpai%252Finstadamn%2BNOT%2Brepo%253AA-Star100%252FA-Star100-AUG2-2024%2BNOT%2Brepo%253Alclnrd%252Fdetox-scrollview-reproductible%2BNOT%2Brepo%253ADionisisChytiris%252FWorldWiseTrivia_Main%2BNOT%2Brepo%253Apast3l%252Fhi2%2BNOT%2Brepo%253AoneDotpy%252FCaribouQuest%2BNOT%2Brepo%253Abejayoharen%252Fdailytodo%2BNOT%2Brepo%253Amolangning%252Freversing-discord%2BNOT%2Brepo%253AScottPrzy%252Freact-native%2BNOT%2Brepo%253Agabrieldonadel%252Freact-native-visionos%2BNOT%2Brepo%253AGabriel2308%252FTestes-Soft%2BNOT%2Brepo%253Adawnzs03%252FflakyBuild%2BNOT%2Brepo%253Acga2351%252Fcode%2BNOT%2Brepo%253Astreeg%252Ftcc%2BNOT%2Brepo%253Asoftware-mansion-labs%252Freact-native-swiftui%2Bcom.facebook.react.devsupport.PerftestDevSupportManager&sa=D&source=editors&ust=1740080026490626&usg=AOvVaw2lrtsZSaLDgxSkejXVrRrp) Changelog: [Internal] [Changed] - Reviewed By: cipolleschi Differential Revision: D69988162 fbshipit-source-id: 475b509417c4e6974d62bab01c089588625fcd8c
…ss (facebook#49377) Summary: Pull Request resolved: facebook#49377 ReactAccessibilityDelegate exists to handle much of the accessibility tasks in the various Views in RN. There is quite a bit of text specific logic, mostly related to virtual views and nested links within a TextView. I decided to subclass this into a TextView-specific version because I need this delegate to reference TextView or ReactClickableSpan, which live under `react/views` while ReactAccessibilityDelegate live under `react/uimanager`. The former depends on the latter, so making the latter depend on the former would for a dependency cycle that would break builds. I thought about making a separate package for this but both `react/views` and `react/uimanager` need to include ReactAccessibilityDelegate so we would still have a cycle. mAccessibilityLinks is only set on ReactTextViewManager, so this is purely a text thing. Subclassing is not the most ideal as it extends the inheritance chain some more but I do not see a better option. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D69499115 fbshipit-source-id: 1720d20bb56ba1e1b5bd114d32bc70e80e3b4558
Summary: Whenever we remove a link in some text we do not properly update the accessibility delegate to respond to this change. As a result we still think that there are nodes to access around the spans Changelog: [Android][Fixed] - Fix text link accessibility on state update removal Reviewed By: NickGerleman, mdvacca Differential Revision: D69551906 fbshipit-source-id: f43fcf72219e76d2d0bbb29d31ab219d73413671
…ok#49381) Summary: Pull Request resolved: facebook#49381 A much improved version of my previous attempt in D68306316 (facebook#48773). Instead of LinkMovementMethod which makes TextViews scrollable if they overflow, this implementation uses `ExploreByTouchHelper`'s `onVirtualViewKeyboardFocusChanged` and `onPerformActionForVirtualView` to handle focus changes and clicks on virtual views (aka spans in our case). This impl will correctly ellipsize text and allow tab to nav through the links. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D69551206 fbshipit-source-id: 6a88ccd507dc5534c1f494e3303c6bfc2bae5e9f
…ebook#49605) Summary: Pull Request resolved: facebook#49605 changelog: [internal] Calling `RCTUnsafeExecuteOnMainQueueSync` while holding a lock can lead to a deadlock. In this diff, we remove it from RCTKeyWindowValuesProxy. Reviewed By: javache Differential Revision: D69997888 fbshipit-source-id: a09fc641c9fb2aec59aef34e4047e1ef11cdaf02
…rkspaces instead of dependencies (#2652)
## Summary: Mitigate GHSA-cxm3-wv7p-598c
## Summary: On older stable branches, our Github repo ruleset looked for a job named "PR", which we have now named "all" in Github Actions. Let's rename the GHA job so that Azure Pipelines and GHA both report success on the same job and we don't need to fork our ruleset. ## Test Plan: Testing in #2650
This PR gets rid of the dependency on @definitelytyped/dtslint in order to mitigate CVE-2025-7783. We are essentially cherry-picking the following commits from facebook upstream. - facebook@2e0c2c6 - facebook@67a6380 --------- Co-authored-by: Saad Najmi <[email protected]>
## Summary: When updating RCTView in #2642, we end up slightly changing the behavior when `didUpdateShadow` is called, causing transparent shadows to crash the app. This breakage occurs because `NSColor colorWithCGColor:` doesn’t accept a `NULL` `CGColorRef`; instead, it raises an exception rather than gracefully returning `nil`. <img height="698" alt="image" src="https://github.com/user-attachments/assets/67413d6e-47e8-47b3-8b29-b9b553cfd19f" /> ## Test Plan: Run RNTester
## Summary: Add guide explaining how to integrate Expo modules in a react-native-macos project ## Test Plan: Run docs locally <img width="1158" height="840" alt="image" src="https://github.com/user-attachments/assets/fdd2663e-d304-4230-a63b-48fb82896449" />
## Summary: Revert #2286 There are 3 commits that make Text Selection work via NSTextView on Fabric, but we only ever merged two of them in. The 3rd (currently in #2673 ) is a work-in-progress, as it currently doesn't work. I need to debug why text selection doesn't work, but as it stands, the diffs to render with an NSTextView add more complexity for not much gain without it. I'd rather reland all the commits together and test with an implementation of Text closer to iOS in the meanwhile. ## Test Plan: CI should pass
) ## Summary: We run `npm publish` if a `.rnm-publish` sentinel file exists, which is created as part of nx release. We were unconditionally creating it, which meant that we would attempt to publish every run, leading to failed publish runs that try to publish over an existing package. This change adds a check to only create the sentinel file if publish detects a change. ## Test Plan: CI should pass
## Summary: This is part of a series of PRs where we are cherry-picking fixes from #2117 to update our Fabric implementation on macOS. This is furthermore, a subset of commits from #2675 . This set specifically implements the text selection APIs on TextInput for macOS, along with another set of commits to reduce our diffs in `RCTCopyBackedTextInput` ## Test Plan: Tested the TextInput selection examples in RNTester. All seem to work well. --------- Co-authored-by: Shawn Dempsey <[email protected]> Co-authored-by: Nick Lefever <[email protected]>
## Summary: Currently all Hermes slices in PR are failing to build (but build locally). ``` 2025-09-17T00:55:31.8097360Z CMake Error at CMakeLists.txt:42 (cmake_policy): 2025-09-17T00:55:31.8097720Z Policy CMP0026 may not be set to OLD behavior because this version of CMake 2025-09-17T00:55:31.8098290Z no longer supports it. The policy was introduced in CMake version 3.0.0, 2025-09-17T00:55:31.8098600Z and use of NEW behavior is now required. 2025-09-17T00:55:31.8098750Z 2025-09-17T00:55:31.8098940Z Please either update your CMakeLists.txt files to conform to the new 2025-09-17T00:55:31.8099330Z behavior or use an older version of CMake that still supports the old 2025-09-17T00:55:31.8099700Z behavior. Run cmake --help-policy CMP0026 for more information. 2025-09-17T00:55:31.8099900Z 2025-09-17T00:55:31.8099900Z 2025-09-17T00:55:31.8101310Z CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles". CMAKE_MAKE_PROGRAM is not set. You probably need to select a different build tool. 2025-09-17T00:55:31.8101980Z CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage 2025-09-17T00:55:31.8102350Z CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage ``` This is because GitHub Actions recently updated the macOS images to cmake 4 (actions/runner-images#12934). Per their comment, use their example script to pin to a lower version ## Test Plan: CI should pass
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.9 to 3.4.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/releases">rexml's releases</a>.</em></p> <blockquote> <h2>REXML 3.4.2 - 2025-08-26</h2> <h3>Improvement</h3> <ul> <li> <p>Improved performance.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/244">GH-244</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/245">GH-245</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/246">GH-246</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/249">GH-249</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/256">GH-256</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Raise appropriate exception when failing to match start tag in DOCTYPE</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/247">GH-247</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Deprecate accepting array as an element in XPath.match, first and each</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/252">GH-252</a></li> <li>Patch by tomoya ishida</li> </ul> </li> <li> <p>Don't call needless encoding_updated</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/259">GH-259</a></li> <li>Patch by Sutou Kouhei</li> </ul> </li> <li> <p>Reuse XPath::match</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/263">GH-263</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Cache redundant calls for doctype</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/264">GH-264</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Use Safe Navigation (&.) from Ruby 2.3</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/265">GH-265</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Remove redundant return statements</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/266">GH-266</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Added XML declaration check & Source#skip_spaces method</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/282">GH-282</a></li> <li>Patch by NAITOH Jun</li> <li>Reported by Sofi Aberegg</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li>Fix docs typo <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/248">GH-248</a></li> <li>Patch by James Coleman</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.4.2 - 2025-08-26 {#version-3-4-2}</h2> <h3>Improvement</h3> <ul> <li> <p>Improved performance.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/244">GH-244</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/245">GH-245</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/246">GH-246</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/249">GH-249</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/256">GH-256</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Raise appropriate exception when failing to match start tag in DOCTYPE</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/247">GH-247</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Deprecate accepting array as an element in XPath.match, first and each</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/252">GH-252</a></li> <li>Patch by tomoya ishida</li> </ul> </li> <li> <p>Don't call needless encoding_updated</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/259">GH-259</a></li> <li>Patch by Sutou Kouhei</li> </ul> </li> <li> <p>Reuse XPath::match</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/263">GH-263</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Cache redundant calls for doctype</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/264">GH-264</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Use Safe Navigation (&.) from Ruby 2.3</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/265">GH-265</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Remove redundant return statements</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/266">GH-266</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Added XML declaration check & Source#skip_spaces method</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/282">GH-282</a></li> <li>Patch by NAITOH Jun</li> <li>Reported by Sofi Aberegg</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li>Fix docs typo <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/248">GH-248</a></li> <li>Patch by James Coleman</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/f36916fe1c66b8cdc1fe482263115625e084d8fe"><code>f36916f</code></a> Add 3.4.2 entry (<a href="https://redirect.github.com/ruby/rexml/issues/284">#284</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/5859bdeac792687eaf93d8e8f0b7e3c1e2ed5c23"><code>5859bde</code></a> Added XML declaration check & <code>Source#skip_spaces</code> method (<a href="https://redirect.github.com/ruby/rexml/issues/282">#282</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/1d876e3bf658b7b4ec7c3372867521695e8eb023"><code>1d876e3</code></a> Bump actions/checkout from 4 to 5 (<a href="https://redirect.github.com/ruby/rexml/issues/283">#283</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/c87bda8bb8773da7e5a0faf9f16ff165eb052a35"><code>c87bda8</code></a> Remove ostruct from dev deps (<a href="https://redirect.github.com/ruby/rexml/issues/281">#281</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/c60ae027a3c20f359fdf76fa41ae64d22313f482"><code>c60ae02</code></a> Remove bundler from dev deps (<a href="https://redirect.github.com/ruby/rexml/issues/277">#277</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/9b084d78708638cedff54743edc0907c4bd6574a"><code>9b084d7</code></a> Fix & Deprecate REXML::Text#text_indent (<a href="https://redirect.github.com/ruby/rexml/issues/275">#275</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/04a589a61bf4e366abee8764ee74b03f4aecc4aa"><code>04a589a</code></a> Fix a bug that XPath can't be used for no document element (<a href="https://redirect.github.com/ruby/rexml/issues/268">#268</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/66232eaf680d0937ae59bea285cdb8e4d3d88a93"><code>66232ea</code></a> Remove redundant return statements (<a href="https://redirect.github.com/ruby/rexml/issues/266">#266</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/63f3e9772595a64b036953f0ab026d2ea5560a3b"><code>63f3e97</code></a> Use Safe Navigation (&.) from Ruby 2.3 (<a href="https://redirect.github.com/ruby/rexml/issues/265">#265</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/d427fc5914fcc17d7247c5ff9099ee38639d6702"><code>d427fc5</code></a> Avoid redundant calls for doctype (<a href="https://redirect.github.com/ruby/rexml/issues/264">#264</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.3.9...v3.4.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/react-native-macos/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Saad Najmi <[email protected]>
## Summary: Merge once macOS 26 is released. Keeping with our usual "N-2" policy (and given that I don't know of anyone asking for lower at the moment), bump the macOS minimum to macOS 14, which in turn allows us to delete some code and use newer APIs. ## Test Plan: CI should pass
## Summary: Revert #2423 in prep for the new architecture as the default for RNM 0.80+ --------- Co-authored-by: Tommy Nguyen <[email protected]>
Needs #2690 to land first. ## Summary: Implement focus on RCTViewComponentView. Much of the implementation is taken from #1437, #2117 and comparing against `RCTView`. The border path used for `drawFocusRingMask` is the same as what is used for box shadows and cursors. ## Test Plan: The focus loop seems nonexistent on both paper and Fabric in RNTester... but I can verify that calling `ref.current?/.focus()` on a Pressable displays the focus ring
…2696) Bumps [rexml](https://github.com/ruby/rexml) from 3.3.9 to 3.4.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/releases">rexml's releases</a>.</em></p> <blockquote> <h2>REXML 3.4.2 - 2025-08-26</h2> <h3>Improvement</h3> <ul> <li> <p>Improved performance.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/244">GH-244</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/245">GH-245</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/246">GH-246</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/249">GH-249</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/256">GH-256</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Raise appropriate exception when failing to match start tag in DOCTYPE</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/247">GH-247</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Deprecate accepting array as an element in XPath.match, first and each</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/252">GH-252</a></li> <li>Patch by tomoya ishida</li> </ul> </li> <li> <p>Don't call needless encoding_updated</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/259">GH-259</a></li> <li>Patch by Sutou Kouhei</li> </ul> </li> <li> <p>Reuse XPath::match</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/263">GH-263</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Cache redundant calls for doctype</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/264">GH-264</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Use Safe Navigation (&.) from Ruby 2.3</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/265">GH-265</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Remove redundant return statements</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/266">GH-266</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Added XML declaration check & Source#skip_spaces method</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/282">GH-282</a></li> <li>Patch by NAITOH Jun</li> <li>Reported by Sofi Aberegg</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li>Fix docs typo <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/248">GH-248</a></li> <li>Patch by James Coleman</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.4.2 - 2025-08-26 {#version-3-4-2}</h2> <h3>Improvement</h3> <ul> <li> <p>Improved performance.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/244">GH-244</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/245">GH-245</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/246">GH-246</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/249">GH-249</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/256">GH-256</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Raise appropriate exception when failing to match start tag in DOCTYPE</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/247">GH-247</a></li> <li>Patch by NAITOH Jun</li> </ul> </li> <li> <p>Deprecate accepting array as an element in XPath.match, first and each</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/252">GH-252</a></li> <li>Patch by tomoya ishida</li> </ul> </li> <li> <p>Don't call needless encoding_updated</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/259">GH-259</a></li> <li>Patch by Sutou Kouhei</li> </ul> </li> <li> <p>Reuse XPath::match</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/263">GH-263</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Cache redundant calls for doctype</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/264">GH-264</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Use Safe Navigation (&.) from Ruby 2.3</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/265">GH-265</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Remove redundant return statements</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/266">GH-266</a></li> <li>Patch by pboling</li> </ul> </li> <li> <p>Added XML declaration check & Source#skip_spaces method</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/282">GH-282</a></li> <li>Patch by NAITOH Jun</li> <li>Reported by Sofi Aberegg</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li>Fix docs typo <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/248">GH-248</a></li> <li>Patch by James Coleman</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/f36916fe1c66b8cdc1fe482263115625e084d8fe"><code>f36916f</code></a> Add 3.4.2 entry (<a href="https://redirect.github.com/ruby/rexml/issues/284">#284</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/5859bdeac792687eaf93d8e8f0b7e3c1e2ed5c23"><code>5859bde</code></a> Added XML declaration check & <code>Source#skip_spaces</code> method (<a href="https://redirect.github.com/ruby/rexml/issues/282">#282</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/1d876e3bf658b7b4ec7c3372867521695e8eb023"><code>1d876e3</code></a> Bump actions/checkout from 4 to 5 (<a href="https://redirect.github.com/ruby/rexml/issues/283">#283</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/c87bda8bb8773da7e5a0faf9f16ff165eb052a35"><code>c87bda8</code></a> Remove ostruct from dev deps (<a href="https://redirect.github.com/ruby/rexml/issues/281">#281</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/c60ae027a3c20f359fdf76fa41ae64d22313f482"><code>c60ae02</code></a> Remove bundler from dev deps (<a href="https://redirect.github.com/ruby/rexml/issues/277">#277</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/9b084d78708638cedff54743edc0907c4bd6574a"><code>9b084d7</code></a> Fix & Deprecate REXML::Text#text_indent (<a href="https://redirect.github.com/ruby/rexml/issues/275">#275</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/04a589a61bf4e366abee8764ee74b03f4aecc4aa"><code>04a589a</code></a> Fix a bug that XPath can't be used for no document element (<a href="https://redirect.github.com/ruby/rexml/issues/268">#268</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/66232eaf680d0937ae59bea285cdb8e4d3d88a93"><code>66232ea</code></a> Remove redundant return statements (<a href="https://redirect.github.com/ruby/rexml/issues/266">#266</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/63f3e9772595a64b036953f0ab026d2ea5560a3b"><code>63f3e97</code></a> Use Safe Navigation (&.) from Ruby 2.3 (<a href="https://redirect.github.com/ruby/rexml/issues/265">#265</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/d427fc5914fcc17d7247c5ff9099ee38639d6702"><code>d427fc5</code></a> Avoid redundant calls for doctype (<a href="https://redirect.github.com/ruby/rexml/issues/264">#264</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.3.9...v3.4.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/react-native-macos/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## Summary: The image `macOS-26` is marked as a beta, let's try bumping to it. ## Test Plan: CI should pass
## Summary: Followup to #2692 , we need to add `focus` and `blur` to the View native components' commands, and implement them so they can be called by JS. This matches what is later implemented upstream in facebook@3e58380 ## Test Plan: `ref.current?.focus()` actually works.
This reverts commit 10b1cd8. ## Summary: The reverted commit moved mouse tracking and handling from `RCTView` to `RCTUIView`. Unfortunately, this includes adding some paper-isms to `RCTUIView`, which is also used by Fabric. We don't use this feature internally anymore, so let's just remove it. In Fabric, it should be much easier to add mouse Tracking to Text since everything is an RCTViewComponentView. ## Test Plan: CI should pass
## Summary: Cherry pick and rebase a bunch of changes to implement onMouseEnter and onMouseLeave for View in Fabric ## Test Plan: The existing test in "Pressable Feedback Events" works in Fabric. --------- Co-authored-by: Nick Lefever <[email protected]> Co-authored-by: Tommy Nguyen <[email protected]>
## Summary: Cherry pick a change from #2117 to add tooltip support ## Test Plan: Existing test page works --------- Co-authored-by: Nick Lefever <[email protected]>
## Summary: Cherry pick more commits from #2117 to implement Drag and Drop Support on View. ## Test Plan: Moved the TextInput example (which doesn't work on Fabric yet) to a new page, and added a View example (which does work on Fabric) https://github.com/user-attachments/assets/b00b25fc-24b9-4587-865f-a05f305d0f40 --------- Co-authored-by: Nick Lefever <[email protected]> Co-authored-by: Tommy Nguyen <[email protected]>
## Summary: - RNTester had a build phase "Build JS Bundle", while RNTester-macOS did not. Let's just copy it over - While we're here, update the OS deployment target to match our minimum. ## Test Plan: CI should pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )